-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply routing form filter by default on /insights/routing #19535
Open
eunjae-lee
wants to merge
6
commits into
main
Choose a base branch
from
eunjae/cal-5207-mandate-routing-form-filter-in-insightsrouting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: apply routing form filter by default on /insights/routing #19535
eunjae-lee
wants to merge
6
commits into
main
from
eunjae/cal-5207-mandate-routing-form-filter-in-insightsrouting
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
6d448aa
to
e0beb0e
Compare
…in-insightsrouting
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/25/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consumer
core
area: core, team members only
ready-for-e2e
routing-forms
area: routing forms, routing, forms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently "Routing Form" filter has been optional. If no routing form is selected, /insights/routing page fetches all the responses from all the accessible forms, and shows all the field columns from all the forms, which ended up having unnecessarily too many columns and it was not easily viewable.
In this PR, now we automatically select the first routing form filter, and users cannot remove it but only can choose one.
Visual Demo (For contributors especially)
Screenshot.2025-02-25.at.15.38.09.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist