Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply routing form filter by default on /insights/routing #19535

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Feb 25, 2025

What does this PR do?

Currently "Routing Form" filter has been optional. If no routing form is selected, /insights/routing page fetches all the responses from all the accessible forms, and shows all the field columns from all the forms, which ended up having unnecessarily too many columns and it was not easily viewable.

In this PR, now we automatically select the first routing form filter, and users cannot remove it but only can choose one.

  • Fixes CAL-5207

Visual Demo (For contributors especially)

Screenshot.2025-02-25.at.15.38.09.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

linear bot commented Feb 25, 2025

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:07pm

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5207-mandate-routing-form-filter-in-insightsrouting branch from 6d448aa to e0beb0e Compare February 25, 2025 14:14
@eunjae-lee eunjae-lee marked this pull request as ready for review February 25, 2025 17:03
@eunjae-lee eunjae-lee changed the title fix: mandate routing form filter on /insights/routing fix: apply routing form filter by default on /insights/routing Feb 25, 2025
@graphite-app graphite-app bot requested a review from a team February 25, 2025 17:04
@dosubot dosubot bot added the routing-forms area: routing forms, routing, forms label Feb 25, 2025
Copy link

graphite-app bot commented Feb 25, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/25/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ready-for-e2e routing-forms area: routing forms, routing, forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants