Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add compression quality prop #130

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Jan 12, 2024

Summary

Allow to change quality of the resulting image via passing quality: number prop. Used the default values without making any breaking changes.

Test plan

Example:

Screen.Recording.2024-01-12.at.17.34.36.mov

@retyui retyui force-pushed the feature/retyui/add-compression-quality-prop branch from a8350e5 to 4b612ce Compare January 12, 2024 16:56
@retyui retyui marked this pull request as ready for review January 12, 2024 17:06
Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls implement quality value validation

ios/RNCImageEditor.mm Show resolved Hide resolved
@retyui retyui force-pushed the feature/retyui/add-compression-quality-prop branch from 4b612ce to b1cbe15 Compare January 15, 2024 10:05
Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retyui retyui merged commit 2991821 into master Jan 15, 2024
6 checks passed
@retyui retyui deleted the feature/retyui/add-compression-quality-prop branch January 15, 2024 10:25
@ionflow
Copy link

ionflow commented Jan 20, 2024

Can you add quality to the ImageCropData type interface? @react-native-community/image-editor/src/index.ts

Object literal may only specify known properties, and 'quality' does not exist in type 'ImageCropData'.ts(2353)
(property) quality: number

retyui added a commit that referenced this pull request Jan 21, 2024
retyui added a commit that referenced this pull request Jan 21, 2024
@retyui
Copy link
Collaborator Author

retyui commented Jan 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants