Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to use base64 uri on Android #132

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Feb 3, 2024

Summary

Test plan

Try cropping the base64 image; it works nicely on iOS but crashes on Android.

      const base64Uri = 'data:image/jpg;base64, ...';
      ImageEditor.cropImage(base64Uri, {
        offset: {x: 0, y: 0},
        size: {width: 100, height:100},
      })

Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but overall looks good 👏

@retyui retyui merged commit 4be0c12 into master Feb 5, 2024
6 checks passed
@retyui retyui deleted the fix/retyui/issue-68 branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants