fix: change number type from float to double

callstack · Sep 20, 2024 · 767ffab · 767ffab
1 parent deaaf3c
commit 767ffab
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 15 deletions.
diff --git a/package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java b/package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
@@ -242,16 +242,12 @@ private void updateValue() {
     setProgress((int) Math.round((mValue - mMinValue) / (mMaxValue - mMinValue) * getTotalSteps()));
   }
 
-  private double roundToSafeValue(double value) {
-    return new BigDecimal(value).setScale(2, RoundingMode.HALF_UP).doubleValue();
-  }
-
   private int getTotalSteps() {
-    return (int) Math.ceil((roundToSafeValue(mMaxValue) - roundToSafeValue(mMinValue)) / getStepValue());
+    return (int) Math.ceil((mMaxValue - mMinValue) / getStepValue());
   }
 
   private double getStepValue() {
-    return roundToSafeValue(mStep > 0 ? mStep : mStepCalculated);
+    return mStep > 0 ? mStep : mStepCalculated;
   }
 
   private BitmapDrawable getBitmapDrawable(final String uri) {

diff --git a/package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java b/package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java
@@ -44,11 +44,11 @@ public static void setValue(ReactSlider view, double value) {
         }
     }
 
-    public static void setMinimumValue(ReactSlider view, float value) {
+    public static void setMinimumValue(ReactSlider view, double value) {
         view.setMinValue(value);
     }
 
-    public static void setMaximumValue(ReactSlider view, float value) {
+    public static void setMaximumValue(ReactSlider view, double value) {
         view.setMaxValue(value);
     }
 
@@ -60,7 +60,7 @@ public static void setUpperLimit(ReactSlider view, double value) {
         view.setUpperLimit(value);
     }
 
-    public static void setStep(ReactSlider view, float value) {
+    public static void setStep(ReactSlider view, double value) {
         view.setStep(value);
     }
 

diff --git a/package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -113,19 +113,19 @@ public void setValue(ReactSlider view, float value) {
 
   @Override
   @ReactProp(name = "minimumValue", defaultFloat = 0f)
-  public void setMinimumValue(ReactSlider view, float value) {
+  public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
   @Override
   @ReactProp(name = "maximumValue", defaultFloat = 0f)
-  public void setMaximumValue(ReactSlider view, float value) {
+  public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
 
   @Override
   @ReactProp(name = "step", defaultFloat = 0f)
-  public void setStep(ReactSlider view, float value) {
+  public void setStep(ReactSlider view, double value) {
     ReactSliderManagerImpl.setStep(view, value);
   }
 

diff --git a/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -131,17 +131,17 @@ public void setValue(ReactSlider view, float value) {
   }
 
   @ReactProp(name = "minimumValue", defaultFloat = 0f)
-  public void setMinimumValue(ReactSlider view, float value) {
+  public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
   @ReactProp(name = "maximumValue", defaultFloat = 1f)
-  public void setMaximumValue(ReactSlider view, float value) {
+  public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
 
   @ReactProp(name = "lowerLimit")
-  public void setLowerLimit(ReactSlider view, float value) {
+  public void setLowerLimit(ReactSlider view, double value) {
     ReactSliderManagerImpl.setLowerLimit(view, value);
   }