Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP to relax type predicates for objects and array-likes #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polytypic
Copy link
Member

@polytypic polytypic commented Oct 10, 2017

Closes #127

  • Consider changing seemsArrayLike to require that length is not an own enumerable property

@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #129    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           1      1            
  Lines        1146    921   -225     
======================================
- Hits         1146    921   -225
Impacted Files Coverage Δ
dist/partial.lenses.cjs.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291b8d8...3d46183. Read the comment docs.

@polytypic polytypic force-pushed the feature/relaxed-object-and-array-like-type-checks branch 3 times, most recently from f07c6cf to 159230c Compare October 17, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants