Skip to content

Commit

Permalink
Merge pull request #820 from cam-inc/fix-default-partitioned-cookie
Browse files Browse the repository at this point in the history
Fix default partitioned cookie
  • Loading branch information
ejithon authored Apr 2, 2024
2 parents 19b2aba + 655c05e commit 239430d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/spotty-kangaroos-shout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@viron/lib": patch
---

Set the partition option to false as the default.
7 changes: 4 additions & 3 deletions packages/nodejs/src/helpers/cookies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ export const genCookie = (
if (!opts.sameSite) {
opts.sameSite = 'none';
}
if (opts.partitioned === undefined) {
opts.partitioned = true;
}
// TODO: Set to true by default after all 3pcd support is complete
// if (opts.partitioned === undefined) {
// opts.partitioned = true;
// }
return serialize(key, value, opts);
};

Expand Down

0 comments on commit 239430d

Please sign in to comment.