Fix chown on copy issue #1448
Open
Fix chown on copy issue #1448
+69
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansferred between containers in the tar archive the ownership is handled by setting the ```CopyUIDGID``` flag in the Docker API call. This should set the files' owner and group to those of the destination container.
…`FileIterator``` class.
… command in the ```OntopService``` class.
…kerClient`, `ContainerClient` and `ContainerService` classes and used it to replace calls to the `sendFilesContent` method when there is only one file. Also tidied up some adjacent code.
gpeb2
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix an issue where transferring files between containers using the Docker API currently requires a
chowncall with user1000, which is rightly disallowed on secure systems.