feat: Internal deduplication impl. #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
10 tasks
NeilJohnson0930
approved these changes
Feb 8, 2025
raywhoelse
approved these changes
Feb 9, 2025
Wendong-Fan
reviewed
Feb 9, 2025
There was a problem hiding this comment.
Thanks @keli-wen @NeilJohnson0930 @raywhoelse
Left some comments below, I think we can implement some methods to further improve the efficiency, feel free to check and review the PR here #1579 for the refactor, let me know if there's anything we can further discuss!
|
|
||
| import numpy as np | ||
| from pydantic import BaseModel | ||
| from sklearn.metrics.pairwise import cosine_similarity |
There was a problem hiding this comment.
use lazy import make sklearn and numpy optional
Comment on lines
+26
to
+27
| """ | ||
| The result of deduplication. |
There was a problem hiding this comment.
docstring format is not aligned with camel style, check https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md#guideline-for-writing-docstrings
|
|
||
| def deduplicate_internally( | ||
| texts: List[str], | ||
| threshold: float = 0.65, |
There was a problem hiding this comment.
should we validate threshold value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation of internal deduplication utils function.
Motivation and Context
Refer to #1517
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!