FUSETOOLS2-2264: Generated tasks.json is not working on Windows

camel-tooling · Nov 22, 2023 · 421d9f3 · 421d9f3
1 parent f55abc5
commit 421d9f3
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 13 deletions.
diff --git a/src/completion/CamelApplicationLauncherTasksCompletionItemProvider.ts b/src/completion/CamelApplicationLauncherTasksCompletionItemProvider.ts
@@ -28,7 +28,7 @@ export class CamelApplicationLauncherTasksCompletionItemProvider implements vsco
 	"command": "mvn", // mvn binary of Maven must be available on command-line
 	"args": [
 		"camel:run",
-		"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+		"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 	],
 	"problemMatcher": "$camel.debug.problemMatcher",
 	"presentation": {
@@ -49,7 +49,7 @@ export class CamelApplicationLauncherTasksCompletionItemProvider implements vsco
 	"args": [
 		"test",
 		"-Dtest=*", // If more than one test is present, a specific one must be specified as a single test can be Camel debugged per launch.
-		"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+		"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 	],
 	"options": {
 		"env": {
@@ -99,7 +99,7 @@ export class CamelApplicationLauncherTasksCompletionItemProvider implements vsco
 	"args": [
 		"compile",
 		"quarkus:dev",
-		"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+		"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 	],
 	"problemMatcher": "$camel.debug.problemMatcher",
 	"presentation": {
@@ -118,14 +118,14 @@ export class CamelApplicationLauncherTasksCompletionItemProvider implements vsco
 	"type": "shell",
 	"command": "jbang", // jbang binary must be available on command-line
 	"args": [
-		"-Dorg.apache.camel.debugger.suspend=true", // requires Camel 3.18+ to take effect
-		"-Dcamel.jbang.version=4.0.0", // to adapt to your Camel version. 3.16+ is required
+		"'-Dorg.apache.camel.debugger.suspend=true'", // requires Camel 3.18+ to take effect
+		"'-Dcamel.jbang.version=4.0.0'", // to adapt to your Camel version. 3.16+ is required
 		"camel@apache/camel",
 		"run",
 		"\${relativeFile}", //to adapt to your workspace, using relativeFile means that the task must be launched when the file to start in debug in the active editor
 		"--logging-level=info",
 		"--reload",
-		"--dep=org.apache.camel:camel-debug"
+		"'--dep=org.apache.camel:camel-debug'"
 	],
 	"problemMatcher": "$camel.debug.problemMatcher",
 	"presentation": {

diff --git a/src/task/CamelJBangTaskProvider.ts b/src/task/CamelJBangTaskProvider.ts
@@ -49,7 +49,10 @@ export class CamelJBangTaskProvider implements TaskProvider {
 					'${relativeFile}',
 					'--dev',
 					'--logging-level=info',
-					'--dep=org.apache.camel:camel-debug',
+					{
+						"value": '--dep=org.apache.camel:camel-debug',
+						"quoting": 2
+					},
 					`${this.getCamelVersion()}`,
 					`${this.getRedHatMavenRepository()}`
 				]

diff --git a/src/ui-test/resources/tasks-examples/01_launch_camel_debug_profile.json b/src/ui-test/resources/tasks-examples/01_launch_camel_debug_profile.json
@@ -10,7 +10,7 @@
 			"args": [
 				"test",
 				"-Dtest=*", // If more than one test is present, a specific one must be specified as a single test can be Camel debugged per launch.
-				"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+				"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 			],
 			"options": {
 				"env": {

diff --git a/src/ui-test/resources/tasks-examples/02_run_jbang_w_camel_debug.json b/src/ui-test/resources/tasks-examples/02_run_jbang_w_camel_debug.json
@@ -8,14 +8,14 @@
 			"type": "shell",
 			"command": "jbang", // jbang binary must be available on command-line
 			"args": [
-				"-Dorg.apache.camel.debugger.suspend=true", // requires Camel 3.18+ to take effect
-				"-Dcamel.jbang.version=4.0.0", // to adapt to your Camel version. 3.16+ is required
+				"'-Dorg.apache.camel.debugger.suspend=true'", // requires Camel 3.18+ to take effect
+				"'-Dcamel.jbang.version=4.0.0'", // to adapt to your Camel version. 3.16+ is required
 				"camel@apache/camel",
 				"run",
 				"${relativeFile}", //to adapt to your workspace, using relativeFile means that the task must be launched when the file to start in debug in the active editor
 				"--logging-level=info",
 				"--reload",
-				"--dep=org.apache.camel:camel-debug"
+				"'--dep=org.apache.camel:camel-debug'"
 			],
 			"problemMatcher": "$camel.debug.problemMatcher",
 			"presentation": {

diff --git a/src/ui-test/resources/tasks-examples/04_start_mvn_quarkus_dev_debug_profile.json b/src/ui-test/resources/tasks-examples/04_start_mvn_quarkus_dev_debug_profile.json
@@ -10,7 +10,7 @@
 			"args": [
 				"compile",
 				"quarkus:dev",
-				"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+				"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 			],
 			"problemMatcher": "$camel.debug.problemMatcher",
 			"presentation": {

diff --git a/src/ui-test/resources/tasks-examples/05_start_mvn_camel_debug_profile.json b/src/ui-test/resources/tasks-examples/05_start_mvn_camel_debug_profile.json
@@ -9,7 +9,7 @@
 			"command": "mvn", // mvn binary of Maven must be available on command-line
 			"args": [
 				"camel:run",
-				"-Pcamel.debug" // This depends on your project. The goal here is to have camel-debug on the classpath.
+				"'-Pcamel.debug'" // This depends on your project. The goal here is to have camel-debug on the classpath.
 			],
 			"problemMatcher": "$camel.debug.problemMatcher",
 			"presentation": {