Merge pull request #14 from camer0nluo/accessibility

feature: support accessibility
camer0nluo · Dec 10, 2023 · f41e743 · f41e743
2 parents 4af14be + 39c5137
commit f41e743
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/web/src/components/ShowHidePassword/ShowHidePassword.tsx b/web/src/components/ShowHidePassword/ShowHidePassword.tsx
@@ -19,7 +19,12 @@ const ShowHidePassword = ({ name }) => {
       ) : (
         <TextField name={name} placeholder=" " required />
       )}
-      <button className="absolute right-6 top-8" onClick={toggleShowPassword}>
+      <button
+        className="absolute right-6 top-8"
+        onClick={toggleShowPassword}
+        aria-label="toggle show hide for password"
+        alt="toggle show hide for password"
+      >
         {isPasswordShowing ? (
           <Icon id="eyeClosed" size={32} />
         ) : (

diff --git a/web/src/pages/RSVPPage/RSVPPage.tsx b/web/src/pages/RSVPPage/RSVPPage.tsx
@@ -45,13 +45,15 @@ const RSVPPage = ({ id }) => {
           <RsvpButton
             className="bg-orangeRed text-white"
             icon="thumbsDown"
+            htmlFor="decline rsvp invite"
             handleButton={handleDecline}
             heading="Regretfully Decline"
           ></RsvpButton>
           <RsvpButton
             className="bg-spanishGreen text-white"
             icon="thumbsUp"
             handleButton={handleAccept}
+            htmlFor="accept rsvp invite"
             heading="Yes, I'll be there"
           ></RsvpButton>
         </div>

diff --git a/web/src/pages/SignupPage/SignupPage.tsx b/web/src/pages/SignupPage/SignupPage.tsx
@@ -36,11 +36,13 @@ const SignupPage = () => {
       <Toaster />
       <div className="container	 mx-auto">
         <HeaderWithRulers heading="Sign Up" className="text-white" />
-        <Form onSubmit={onSubmit}>
-          <Input name="Name" />
-          <Input name="Email" />
-          <ShowHidePassword name="Password" />
+        <Form onSubmit={onSubmit} htmlFor="form">
+          <Input name="Name" htmlFor="name" />
+          <Input name="Email" htmlFor="email" />
+          <ShowHidePassword name="Password" htmlFor="password" />
           <Submit
+            htmlFor="submit"
+            alt="submit button"
             className="
       w-full
     rounded-full bg-supernova py-5 font-handwriting text-3xl uppercase text-black"