fixup! MDL-82587 mod_quiz: Add slot version updated event

cameron1729 · Aug 1, 2024 · 4d9356a · 4d9356a
1 parent fe8cf17
commit 4d9356a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/mod/quiz/amd/build/question_slot.min.js b/mod/quiz/amd/build/question_slot.min.js
diff --git a/mod/quiz/amd/build/question_slot.min.js.map b/mod/quiz/amd/build/question_slot.min.js.map
diff --git a/mod/quiz/amd/src/question_slot.js b/mod/quiz/amd/src/question_slot.js
@@ -45,7 +45,6 @@ const setQuestionVersion = (slotId, newVersion) => fetchMany([{
  */
 const registerEventListeners = () => {
     document.addEventListener('change', e => {
-        window.console.log('changed');
         if (!e.target.matches('[data-action="mod_quiz-select_slot"][data-slot-id]')) {
             return;
         }

diff --git a/mod/quiz/classes/structure.php b/mod/quiz/classes/structure.php
@@ -1185,7 +1185,7 @@ public function update_slot_version(int $id, ?int $newversion): bool {
         $context = $this->quizobj->get_context();
         $refparams = ['usingcontextid' => $context->id, 'component' => 'mod_quiz', 'questionarea' => 'slot', 'itemid' => $slot->id];
         $reference = $DB->get_record('question_references', $refparams, '*', MUST_EXIST);
-        $oldversion = (int)$reference->version;
+        $oldversion = is_null($reference->version) ? null : (int) $reference->version;
         $reference->version = $newversion === 0 ? null : $newversion;
         $existsparams = ['questionbankentryid' => $reference->questionbankentryid, 'version' => $newversion];
         $versionexists = $DB->record_exists('question_versions', $existsparams);