Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bin/ utilities #267

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix bin/ utilities #267

merged 1 commit into from
Jan 18, 2024

Conversation

gurneyalex
Copy link
Member

local-src is no longer used -> things are now in /odoo/odoo/addons

@gurneyalex gurneyalex force-pushed the fix-scripts branch 3 times, most recently from acc647e to ce0c9f8 Compare January 4, 2024 10:57
Copy link
Member

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@gurneyalex
Copy link
Member Author

I'm fixing the CI :-/

COPY ./src /odoo/src/odoo
COPY ./external-src /odoo/external-src
COPY ./local-src /odoo/local-src
COPY ./odoo/src/odoo /odoo/src/odoo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying only ./odoo/src/odoo is ok, but you also need to copy ./odoo/src/setup.py to be able to pip install it.

Copy link
Member Author

@gurneyalex gurneyalex Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I have misinterpreted https://github.com/camptocamp/docker-odoo-project/blob/master/test.sh#L66 as moving the extracted directory in a sub directory of /odoo/src

Copy link
Member

@yvaucher yvaucher Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I missed your change on https://github.com/camptocamp/docker-odoo-project/pull/267/files#diff-3722d9ba8feb2d3feac8ce71a209a638d4b404e1c53f937188761181594023e2R67-R68

Which confused me.

So far I have not seen where the issue comes from. The path change seems to be the ideal culprit but I didn't find enough evidences to blame it yet. 🧑‍⚖️ so back to investiguation.

@gurneyalex
Copy link
Member Author

thanks @vrenaville and @yvaucher for looking into this.

local-src is no longer used -> things are now in /odoo/odoo/addons
@gurneyalex
Copy link
Member Author

I just rebased + squash

@gurneyalex gurneyalex merged commit 42edd0f into camptocamp:master Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants