Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distlib-css-bundle #9506

Closed
wants to merge 1 commit into from
Closed

Fix distlib-css-bundle #9506

wants to merge 1 commit into from

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Oct 10, 2024 •
edited
Loading

For GSNGEO-21
Makes more sens.

Examples
Storybook
API help
API documentation

@ger-benjamin ger-benjamin self-assigned this Oct 10, 2024
sbrunner
sbrunner requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

His doesn't remove the hash!
Or I don't understand what you want to do?

@ger-benjamin
Copy link
Member Author

Yes, ok, I forgot why you did that.
But cp dist/desktop-*.css distlib/src/controllers/desktop.css doesn't work => destination is not a folder

sbrunner
sbrunner reviewed Oct 10, 2024
View reviewed changes
package.json Show resolved Hide resolved
@ger-benjamin
Copy link
Member Author

I was confused because multiple file in my dist, instead of one.
this PR is useless and based on a missunderstandnis

@ger-benjamin ger-benjamin deleted the fix-distlib-css-bundle branch October 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner requested changes

Assignees

@ger-benjamin ger-benjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ger-benjamin @sbrunner