chore: fix grpc interfaces for new method

camunda · Jan 13, 2025 · 46b17c2 · 46b17c2
1 parent e51853b
commit 46b17c2
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 8 deletions.
diff --git a/...ests__/testdata/Worker-JobCorrection.bpmn → src/__tests__/testdata/Worker-JobResult.bpmn b/...ests__/testdata/Worker-JobCorrection.bpmn → src/__tests__/testdata/Worker-JobResult.bpmn
diff --git a/src/__tests__/zeebe/integration/Worker-CompleteWithResult.spec.ts b/src/__tests__/zeebe/integration/Worker-CompleteWithResult.spec.ts
@@ -13,7 +13,7 @@ let bpmnProcessId1: string
 
 beforeAll(async () => {
 	const res1 = await zbc.deployResource({
-		processFilename: './src/__tests__/testdata/Worker-JobCorrection.bpmn',
+		processFilename: './src/__tests__/testdata/Worker-JobResult.bpmn',
 	})
 	;({
 		processDefinitionKey: processDefinitionKey1,
@@ -48,7 +48,9 @@ test('Can complete a task with job corrections', (done) => {
 					expect(job.processInstanceKey).toBe(wf?.processInstanceKey)
 					const res1 = await job.completeWithJobResult({
 						variables: {},
-						result: {},
+						result: {
+							denied: true,
+						},
 					})
 					// @TODO: correction interface
 					done(null)

diff --git a/src/zeebe/lib/ZBStreamWorker.ts b/src/zeebe/lib/ZBStreamWorker.ts
@@ -15,7 +15,11 @@ import {
 	ZBGrpc,
 	ZBWorkerTaskHandler,
 } from './interfaces-1.0'
-import { ActivatedJob, StreamActivatedJobsRequest } from './interfaces-grpc-1.0'
+import {
+	ActivatedJob,
+	CompleteJobRequest,
+	StreamActivatedJobsRequest,
+} from './interfaces-grpc-1.0'
 
 import { parseVariablesAndCustomHeadersToJSON } from '.'
 
@@ -195,13 +199,30 @@ You should call only one job action method in the worker handler. This is a bug
 				})
 			}
 
+		const correctJob =
+			(job: Job) => (req: Pick<CompleteJobRequest, 'result' | 'variables'>) =>
+				this.completeJob(
+					job.key,
+					{
+						result: req.result,
+						variables: req.variables,
+					},
+					taskType
+				)
+
 		const fail = failJob(thisJob)
 		const succeed = succeedJob(thisJob)
+		const completeWithResult = correctJob(thisJob)
+
 		return {
 			cancelWorkflow: cancelWorkflow(thisJob),
 			complete: errorMsgOnPriorMessageCall('job.complete', succeed),
 			error: errorMsgOnPriorMessageCall('error', errorJob(thisJob)),
 			fail: errorMsgOnPriorMessageCall('job.fail', fail),
+			completeWithJobResult: errorMsgOnPriorMessageCall(
+				'job.completeWithJobResult',
+				completeWithResult
+			),
 			forward: errorMsgOnPriorMessageCall('job.forward', () => {
 				return JOB_ACTION_ACKNOWLEDGEMENT
 			}),

diff --git a/src/zeebe/zb/ZBWorker.ts b/src/zeebe/zb/ZBWorker.ts
@@ -49,11 +49,7 @@ export class ZBWorker<
 			)(
 				{
 					...job,
-					cancelWorkflow: workerCallback.cancelWorkflow,
-					complete: workerCallback.complete,
-					fail: workerCallback.fail,
-					error: workerCallback.error,
-					forward: workerCallback.forward,
+					...workerCallback,
 				},
 				this
 			)