Suggest element id as variable name #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
83-suggest-element-id-instead-of-name
branch
from
9a59036 to
496f68d
Compare
deps: update to `[email protected]` Closes #83
barmac
force-pushed
the
83-suggest-element-id-instead-of-name
branch
from
496f68d to
1a17018
Compare
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
bpmn-io-tasks
bot
added
needs review
nikku
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
I can conform that it works and that the implementation is simple enough!
What I found is that we can make our completion even more powerful with, i.e. literal expressions: If we have a Decision Foo_Bar and the literal expression exports a { name: "WALT" } context, then Foo_Bar.name is something that I'd assume would be auto-suggested to me. Not sure if this is a bug or a missing feature.
|
This is a missing feature in dmn-variable-resolver. |
|
@nikku I created an issue for your suggestion: bpmn-io/dmn-variable-resolver#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
Requires bpmn-io/dmn-variable-resolver#10 to be integrated.