Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(element-templates): added "implementationType" property for execution listeners #2667

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

AlexanderSkrock
Copy link
Contributor

@AlexanderSkrock AlexanderSkrock commented Sep 28, 2023

Supports solving the following issue: bpmn-io/bpmn-js-element-templates#13
Reflects changes in behaviour proposed with: bpmn-io/bpmn-js-element-templates#17

@christinaausley christinaausley added component:modeler Issues related with Modeler project component:docs Documentation improvements, including new or updated content labels Sep 28, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@barmac barmac force-pushed the named-property-binding branch from 673294c to 119a13d Compare October 5, 2023 08:39
@barmac barmac force-pushed the named-property-binding branch from 7e6a8f8 to 4a6760d Compare October 10, 2023 09:33
@AlexanderSkrock AlexanderSkrock changed the title feat(element-templates): added name property for execution listeners feat(element-templates): added "implementationType" property for execution listeners Oct 10, 2023
@akeller
Copy link
Member

akeller commented Oct 10, 2023

@barmac @nikku can you please review?

@barmac
Copy link
Contributor

barmac commented Oct 11, 2023

Hi, I'm on it, but want to first merge the documented feature.

@barmac barmac force-pushed the named-property-binding branch from 4a6760d to e9f3642 Compare October 11, 2023 07:05
@akeller
Copy link
Member

akeller commented Oct 11, 2023

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @AlexanderSkrock, we had some issues with our CLA over the last few days. Can you please sign it?

@AlexanderSkrock
Copy link
Contributor Author

Hi @AlexanderSkrock, we had some issues with our CLA over the last few days. Can you please sign it?

I just resigned the CLA and according to pull request checks it seems to be alright now.

Kind regards
Alexander Skrock

Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documents precisely what was implemented via bpmn-io/bpmn-js-element-templates#17. The documentation change will apply only to the future releases.

@christinaausley
Copy link
Contributor

@AlexanderSkrock @barmac Are there additional changes here, or are we ready to merge?

@barmac
Copy link
Contributor

barmac commented Oct 16, 2023

If there's 👍 from you then I believe it's ready to be merged :)

@AlexanderSkrock
Copy link
Contributor Author

I agree with @barmac , all related pull requests are merged.

@christinaausley christinaausley merged commit 2c04e73 into camunda:main Oct 16, 2023
@AlexanderSkrock AlexanderSkrock deleted the named-property-binding branch October 16, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:modeler Issues related with Modeler project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants