-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(element-templates): added "implementationType" property for execution listeners #2667
feat(element-templates): added "implementationType" property for execution listeners #2667
Conversation
|
673294c
to
119a13d
Compare
7e6a8f8
to
4a6760d
Compare
Hi, I'm on it, but want to first merge the documented feature. |
…to support classes, expressions and delegate expressions
4a6760d
to
e9f3642
Compare
Hi @AlexanderSkrock, we had some issues with our CLA over the last few days. Can you please sign it? |
I just resigned the CLA and according to pull request checks it seems to be alright now. Kind regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documents precisely what was implemented via bpmn-io/bpmn-js-element-templates#17. The documentation change will apply only to the future releases.
@AlexanderSkrock @barmac Are there additional changes here, or are we ready to merge? |
If there's 👍 from you then I believe it's ready to be merged :) |
I agree with @barmac , all related pull requests are merged. |
Supports solving the following issue: bpmn-io/bpmn-js-element-templates#13
Reflects changes in behaviour proposed with: bpmn-io/bpmn-js-element-templates#17