-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(self-managed): refine docker compose page #4816
docs(self-managed): refine docker compose page #4816
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
2aa676d
to
8b47e4f
Compare
bc7c536
to
7b5efd5
Compare
I'm good with these changes. I'm going to leave some comments for a few typos I found. |
Actually I think it was just the word "Contains", the rest looks fine. |
@aabouzaid this is still in draft with no details or links in the description, but please be sure to add a tech writer for review before merging. |
7b5efd5
to
b82d9c2
Compare
e3d4e68
to
9da32a8
Compare
@jessesimpson36 Thanks for the review, all points addressed ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few separate notes, but had a few overall questions when testing these steps.
It looks like these instructions come from the deprecated repo, which means several steps are outdated, or otherwise don't apply to the current setup in the new repo/in later versions.
The 8.6 and 8.7 compose files in the new repo require the use of --profile full
to run; is this intended? Prior versions don't seem to require the profile.
Can you confirm:
- We should remove the Web Modeler file references/separate instructions after 8.6
--profile full
should be used running the full docker compose file after 8.6- That the other sections are up-to-date
I can go through and test the differences/update the instructions, but wanted to make sure the above was correct first. Thank you!
@conceptualshark Thanks for your review 🙌 We have some inconsistencies, so it would be great if you could review the documents to ensure that everything works as expected. However, we will review the whole Docker Compose docs again because it didn't follow the same process as we had for Helm (and that's the idea of the SM repo). Also, we will move away from that style (cloning) and provide artifacts to be downloaded directly. Answering the questions:
They are needed for the standalone Web Modeler (they were missing in the new repo, and I've added them).
I will check that and get back to you.
We need to verify that, but in general, that is what we have now anyway, and for sure, we need to review that. |
That has been reverted in favor of having a separate Docker Compose file for each case (many users were confused because of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few changes to the docker instructions in /next (docs/self-managed/setup/deploy/local/docker-compose.md) and started a preview site so it's a little easier to see changes. I've left a few open questions as individual comments. I also might have stepped on a few in-progress changes, sorry! I wasn't sure which issues had been fixed/pushed.
Once things look good structurally, I can update the older versions as well.
|
||
Alternatively, you can mount new Connector JARs as volumes into the `/opt/app` folder by adding this to the Docker Compose file. Keep in mind that the Connector JARs must include all necessary dependencies inside the JAR. | ||
|
||
## Kibana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've formatted/edited these instructions, but the Kibana profile doesn't run for me in the provided 8.6 or alpha/8.7 compose file. Not sure if this is an error in my setup or in the profile. Can you verify Kibana works and that these instructions are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it with Camunda 8.6 Docker Compose, and it works as expected.
What issue/error do you have?
362bae7
to
50a3a81
Compare
@conceptualshark I'm done with all comments 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and tested again, and backported these changes through 8.5. 8.6 looks the same as what was added, and in 8.5 the note about Web Modeler being included by default/any other descriptions about this have been removed.
This looks good to me at this point, let me know if it needs anything else! 👍
For records, I've also updated the SM CI to test all versions and variations as we have them in the docs. Also, as mentioned, we will have another refinement cycle for Docker Compose to work on the 8.7 updates. @conceptualshark Feel free to merge the PR (I can merge it if that's fine). |
🧹 Preview environment for this PR has been torn down. |
Description
Task: https://github.com/camunda/distribution/issues/287
We are moving the Docker Compose from camunda/camunda-platform repo to camunda/camunda-self-managed.
When should this change go live?
ASAP
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).