Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-managed): refine docker compose page #4816

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Jan 3, 2025

Description

Task: https://github.com/camunda/distribution/issues/287

We are moving the Docker Compose from camunda/camunda-platform repo to camunda/camunda-self-managed.

When should this change go live?

ASAP

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@aabouzaid aabouzaid self-assigned this Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@aabouzaid aabouzaid force-pushed the distro-287-aa-update-docker-compose-docs branch from 2aa676d to 8b47e4f Compare January 3, 2025 09:55
@aabouzaid aabouzaid force-pushed the distro-287-aa-update-docker-compose-docs branch 2 times, most recently from bc7c536 to 7b5efd5 Compare January 3, 2025 10:25
@aabouzaid aabouzaid requested a review from a team January 3, 2025 10:37
@jessesimpson36
Copy link
Contributor

I'm good with these changes. I'm going to leave some comments for a few typos I found.

@jessesimpson36
Copy link
Contributor

Actually I think it was just the word "Contains", the rest looks fine.

jessesimpson36
jessesimpson36 previously approved these changes Jan 3, 2025
@akeller
Copy link
Member

akeller commented Jan 6, 2025

@aabouzaid this is still in draft with no details or links in the description, but please be sure to add a tech writer for review before merging.

@aabouzaid aabouzaid force-pushed the distro-287-aa-update-docker-compose-docs branch from 7b5efd5 to b82d9c2 Compare January 7, 2025 11:23
@aabouzaid aabouzaid force-pushed the distro-287-aa-update-docker-compose-docs branch from e3d4e68 to 9da32a8 Compare January 7, 2025 12:38
@aabouzaid aabouzaid requested a review from a team January 7, 2025 18:07
@aabouzaid
Copy link
Member Author

@jessesimpson36 Thanks for the review, all points addressed ✔️
@akeller No worries, I usually leave the merge to the repo maintainers 😁

@aabouzaid aabouzaid marked this pull request as ready for review January 7, 2025 18:08
@conceptualshark conceptualshark self-requested a review January 7, 2025 19:27
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few separate notes, but had a few overall questions when testing these steps.

It looks like these instructions come from the deprecated repo, which means several steps are outdated, or otherwise don't apply to the current setup in the new repo/in later versions.

The 8.6 and 8.7 compose files in the new repo require the use of --profile full to run; is this intended? Prior versions don't seem to require the profile.

Can you confirm:

  • We should remove the Web Modeler file references/separate instructions after 8.6
  • --profile full should be used running the full docker compose file after 8.6
  • That the other sections are up-to-date

I can go through and test the differences/update the instructions, but wanted to make sure the above was correct first. Thank you!

@aabouzaid
Copy link
Member Author

@conceptualshark Thanks for your review 🙌

We have some inconsistencies, so it would be great if you could review the documents to ensure that everything works as expected.

However, we will review the whole Docker Compose docs again because it didn't follow the same process as we had for Helm (and that's the idea of the SM repo).

Also, we will move away from that style (cloning) and provide artifacts to be downloaded directly.
But that's not here yet.


Answering the questions:

We should remove the Web Modeler file references/separate instructions after 8.6

They are needed for the standalone Web Modeler (they were missing in the new repo, and I've added them).

--profile full should be used running the full docker compose file after 8.6

I will check that and get back to you.

That the other sections are up-to-date

We need to verify that, but in general, that is what we have now anyway, and for sure, we need to review that.

@aabouzaid
Copy link
Member Author

--profile full should be used running the full docker compose file after 8.6
I will check that and get back to you.

That has been reverted in favor of having a separate Docker Compose file for each case (many users were confused because of using --profile).

@conceptualshark conceptualshark added component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR labels Jan 8, 2025
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few changes to the docker instructions in /next (docs/self-managed/setup/deploy/local/docker-compose.md) and started a preview site so it's a little easier to see changes. I've left a few open questions as individual comments. I also might have stepped on a few in-progress changes, sorry! I wasn't sure which issues had been fixed/pushed.

Once things look good structurally, I can update the older versions as well.


Alternatively, you can mount new Connector JARs as volumes into the `/opt/app` folder by adding this to the Docker Compose file. Keep in mind that the Connector JARs must include all necessary dependencies inside the JAR.

## Kibana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've formatted/edited these instructions, but the Kibana profile doesn't run for me in the provided 8.6 or alpha/8.7 compose file. Not sure if this is an error in my setup or in the profile. Can you verify Kibana works and that these instructions are correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried it with Camunda 8.6 Docker Compose, and it works as expected.
What issue/error do you have?

docs/self-managed/setup/deploy/local/docker-compose.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/local/docker-compose.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to camunda-docs January 8, 2025 20:49 Destroyed
@aabouzaid aabouzaid force-pushed the distro-287-aa-update-docker-compose-docs branch from 362bae7 to 50a3a81 Compare January 9, 2025 06:59
@github-actions github-actions bot temporarily deployed to camunda-docs January 9, 2025 07:12 Destroyed
@aabouzaid
Copy link
Member Author

@conceptualshark I'm done with all comments 🙌

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and tested again, and backported these changes through 8.5. 8.6 looks the same as what was added, and in 8.5 the note about Web Modeler being included by default/any other descriptions about this have been removed.

This looks good to me at this point, let me know if it needs anything else! 👍

@github-actions github-actions bot temporarily deployed to camunda-docs January 9, 2025 20:53 Destroyed
@aabouzaid
Copy link
Member Author

For records, I've also updated the SM CI to test all versions and variations as we have them in the docs.
camunda/camunda-self-managed#50

Also, as mentioned, we will have another refinement cycle for Docker Compose to work on the 8.7 updates.

@conceptualshark Feel free to merge the PR (I can merge it if that's fine).

@conceptualshark conceptualshark merged commit 763625e into main Jan 10, 2025
8 checks passed
@conceptualshark conceptualshark deleted the distro-287-aa-update-docker-compose-docs branch January 10, 2025 15:33
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants