Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add sorting parameter #285

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

danielkelemen
Copy link
Member

lib/__snapshots__/Client.test.js.snap Outdated Show resolved Hide resolved
@danielkelemen danielkelemen changed the title feat(client): add sortings parameter feat(client): add sorting parameter Jan 5, 2024
@danielkelemen danielkelemen requested a review from tasso94 January 5, 2024 09:54
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered one problem through manual testing we should address. Otherwise, it looks good to me 👍

lib/Client.js Outdated Show resolved Hide resolved
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielkelemen danielkelemen merged commit 036b73e into master Jan 22, 2024
5 checks passed
@danielkelemen danielkelemen deleted the 3928-add-sortings branch January 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants