Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump forms dependencies #3570

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Bump forms dependencies #3570

merged 2 commits into from
Apr 26, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus requested review from a team, smbea and barmac and removed request for a team April 25, 2023 13:58
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 25, 2023
@nikku nikku self-requested a review April 26, 2023 07:45
@nikku
Copy link
Member

nikku commented Apr 26, 2023

I played around with it and found no issues. Two things I stumbled upon though:

  • Moving form fields still feel clunky:

    capture eix0il_optimized

  • Resize handles are gone. Where did they go?

@nikku nikku merged commit ad2ed41 into develop Apr 26, 2023
@nikku nikku deleted the bump-form-js branch April 26, 2023 11:57
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 26, 2023
@pinussilvestrus
Copy link
Contributor Author

  • Moving form fields still feel clunky:

This will hopefully be improved once we move to dragula@2

Resize handles are gone. Where did they go?

Resize handles are not released yet - not sure where you saw them, maybe a demo?

@pinussilvestrus
Copy link
Contributor Author

/cc @marcellobarile @CatalinaMoisuc I think it makes sense to bump the same versions in the Web Modeler. I'm not familiar with the setup, so I can't do that on my own, unfortunately 😅

@marcellobarile
Copy link

@pinussilvestrus thanks for the heads up, we should get the bump from the Renovate bot along with other bpmnio libraries updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support attribute "required" for checkboxes
3 participants