Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version tf lint #64

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: version tf lint #64

merged 1 commit into from
Jun 4, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Jun 3, 2024

This PR fixes the hardcoded version of tfdoc that breaks when it's not synced with the one defined in asdf.
In order to fix that, I propose that we let asdf be the single source of trust.

Related PR #61

@leiicamundi leiicamundi requested a review from Langleu June 3, 2024 11:46
@leiicamundi leiicamundi marked this pull request as ready for review June 3, 2024 11:46
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, omitting it completely but should work this way as well.

@leiicamundi leiicamundi merged commit 0ad31e9 into main Jun 4, 2024
4 checks passed
@leiicamundi leiicamundi deleted the feature/fix-version-tf branch June 4, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants