chore: allow feel: required on Boolean an Number

camunda · Feb 6, 2024 · 1723ead · 1723ead
1 parent 92022b2
commit 1723ead
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 55 deletions.
diff --git a/packages/zeebe-element-templates-json-schema/src/defs/properties.json b/packages/zeebe-element-templates-json-schema/src/defs/properties.json
@@ -254,31 +254,6 @@
             }
           }
         }
-      },
-      {
-        "if": {
-          "properties": {
-            "type": {
-                "enum": [
-                  "Boolean",
-                  "Number"
-                ]
-            }
-          },
-          "required": [
-            "feel"
-          ]
-        },
-        "then": {
-          "properties": {
-            "feel": {
-              "enum": [
-                "optional",
-                "staticValue"
-              ]
-            }
-          }
-        }
       }
     ],
     "properties": {

diff --git a/packages/zeebe-element-templates-json-schema/test/fixtures/feel-type-mismatch.js b/packages/zeebe-element-templates-json-schema/test/fixtures/feel-type-mismatch.js
@@ -13,15 +13,6 @@ export const template = {
         name: 'prop'
       },
       feel: 'staticValue'
-    },
-    {
-      label: 'Number (required)',
-      type: 'Number',
-      binding: {
-        type: 'property',
-        name: 'prop'
-      },
-      feel: 'required'
     }
   ]
 };
@@ -49,27 +40,6 @@ export const errors =
     },
     schemaPath: '#/allOf/1/items/allOf/8/if'
   },
-  {
-    dataPath: '/properties/1/feel',
-    keyword: 'enum',
-    message: 'should be equal to one of the allowed values',
-    params: {
-      allowedValues: [
-        'optional',
-        'staticValue'
-      ]
-    },
-    schemaPath: '#/allOf/1/items/allOf/9/then/properties/feel/enum'
-  },
-  {
-    dataPath: '/properties/1',
-    keyword: 'if',
-    message: 'should match "then" schema',
-    params: {
-      failingKeyword: 'then'
-    },
-    schemaPath: '#/allOf/1/items/allOf/9/if'
-  },
   {
     dataPath: '',
     keyword: 'type',