Implement zeebe:taskDefinition binding
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binding was never implemented in bpmn-js-element-templates. It is unnecessary with introduction of `zeebe:taskDefinition` binding. BREAKING CHANGE: `zeebe:taskDefinition:retries` binding is removed.
The binding is replaced with `zeebe:taskDefinition` which suggests both `retries` and `type` property names.
barmac
force-pushed
the
implement-zeebe-task-definition-binding
branch
from
99d84d5 to
70574dd
Compare
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
bpmn-io-tasks
bot
added
needs review
marstamm
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
zeebe:taskDefinitionbinding which allows to fully configure task definition:{ "binding": { "type": "zeebe:taskDefinition", "property": "retries" } }, { "binding": { "type": "zeebe:taskDefinition", "property": "type" } }This PR also removes obsolete
zeebe:taskDefinition:retriesbinding. The binding was never implemented in bpmn-js-element-templates. It is unnecessary with introduction ofzeebe:taskDefinitionbinding.BREAKING CHANGE:
zeebe:taskDefinition:retriesbinding is removed.Related to camunda/camunda-modeler#2936