feat: support receive and send task templating #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
barmac
commented
Nov 8, 2023
Comment on lines
-15
to
-21
| "properties": { | ||
| "eventDefinition": { | ||
| "enum": [ | ||
| "bpmn:MessageEventDefinition" | ||
| ] | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is redundant. If event definition is set, the value has to be one of the events regardless of the event definition value.
barmac
commented
Nov 8, 2023
Comment on lines
-2
to
-3
| 'name': 'MissingBindingName', | ||
| 'id': 'com.camunda.example.MissingBindingName', |
There was a problem hiding this comment.
Removing copy-paste-driven development mark here ;)
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
|
I can look into this today |
smbea
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Should we also change the "copy-paste-driven development mark" in this file while you're at it? This part:
'name': 'MissingBindingName',
'id': 'com.camunda.example.MissingBindingName',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#3573