Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(condition): add isActive condition #120

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat(condition): add isActive condition #120

merged 1 commit into from
Nov 22, 2023

Conversation

marstamm
Copy link
Member

@marstamm marstamm requested a review from a team November 16, 2023 12:30
@marstamm marstamm self-assigned this Nov 16, 2023
@marstamm marstamm requested review from philippfromme and smbea and removed request for a team November 16, 2023 12:30
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 16, 2023
@sbuettner sbuettner mentioned this pull request Nov 20, 2023
Closed
4 tasks
@barmac
Copy link
Contributor

barmac commented Nov 21, 2023

Shall we add a description to the new field? I don't think it's self-explanatory from the name.

@barmac
Copy link
Contributor

barmac commented Nov 21, 2023

This could be something like:

Activates property based on whether linked property is active.

Let's also not forget to document when bpmn:Message#zeebe:subscription#property of name=correlationKey is implicitly hidden ^^

@marstamm
Copy link
Member Author

Let's also not forget to document when bpmn:Message#zeebe:subscription#property of name=correlationKey is implicitly hidden ^^

Where would be the best place to do this? Just the description of the name property or do we need to be more specific?

@barmac
Copy link
Contributor

barmac commented Nov 21, 2023

Camunda Docs once this PR is merged: camunda/camunda-docs#2923

@barmac
Copy link
Contributor

barmac commented Nov 21, 2023

Regarding description, see: https://github.com/camunda/element-templates-json-schema/pull/120/files#r1400472914

@marstamm marstamm force-pushed the add-is-visible-condtion branch from 0ce07e9 to 15a9a3b Compare November 21, 2023 12:10
@barmac
Copy link
Contributor

barmac commented Nov 21, 2023

Hmm maybe we call it isActive instead? So that it cannot be confused due to Hidden type.

@marstamm
Copy link
Member Author

Sounds good, since the logic has nothing to do with visibility. I'll get to it

@marstamm marstamm force-pushed the add-is-visible-condtion branch from 15a9a3b to 6ca4101 Compare November 21, 2023 13:23
@marstamm marstamm merged commit 2ab4d91 into main Nov 22, 2023
2 checks passed
@marstamm marstamm deleted the add-is-visible-condtion branch November 22, 2023 09:18
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2023
@nikku nikku changed the title feat(condition): add isVisible condition feat(condition): add isActive condition Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from camunda/modeling-dev

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from camunda/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marstamm @barmac