Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow subscription binding for bpmn:SendTask #122

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Nov 24, 2023

  • FIX: disallow bpmn:Message#zeebe:subscription#property binding for bpmn:SendTask

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team November 24, 2023 11:05
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 24, 2023

* `FIX`: disallow `bpmn:Message#zeebe:subscription#property` binding for `bpmn:SendTask`

### Breaking Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is breaking, as it is a bug fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's change it.

The property is not allowed for messages to be sent so it does
not make sense to make it templatable.
@barmac barmac force-pushed the unbuild-send-task-zeebe-subscription branch from d134b5c to 79d2441 Compare November 27, 2023 08:38
@barmac barmac requested a review from nikku November 27, 2023 08:39
@barmac
Copy link
Contributor Author

barmac commented Nov 27, 2023

I changed it to a fix -> patch release.

@barmac barmac merged commit d3ffc12 into main Nov 27, 2023
2 checks passed
@barmac barmac deleted the unbuild-send-task-zeebe-subscription branch November 27, 2023 14:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants