feat(zeebe): allow number and boolean everywhere #132
Conversation
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
| "optional", | ||
| "staticValue" |
There was a problem hiding this comment.
Why can't this be "feel": "required"?
There was a problem hiding this comment.
I guess it's because the number/boolean controls wouldn't be displayed, but in that case the template developer may want to express the semantics of the field: "This has to be an expression which returns boolean" for which { type: "Boolean", feel: "required" } makes sense.
There was a problem hiding this comment.
My initial reasoning was that "feel": "required" will always result in just a FEEL editor without further validation. It does no longer offer the Restrictions/UI of Number or Boolean fields. Therefore I think we should disallow it if the result we display would be a Text Input anyway.
You make a valid point and I see how this can offer more options, so I'll add adjust it
There was a problem hiding this comment.
Did we consider static as a simpler version of staticValue? I'd imagine both would need explanation anyway, and in these cases I'd prefer the shorter form.
| @@ -20,61 +20,16 @@ export const template = { | |||
| 'type': 'zeebe:input', | |||
| 'name': 'bar' | |||
| } | |||
There was a problem hiding this comment.
The fixture name is now misleading. Let's add some absurd type instead, e.g. type: Car
There was a problem hiding this comment.
Missed that one, I adjusted it for every other test. No idea why I did not do it with this one 🙈
adjusted and squashed with previous commits
marstamm
force-pushed
the
allow-number-boolean-everywhere
branch
from
97699ca to
c7c02ad
Compare
staticValueoption for feel, only valid on Number and Booleanrelated to camunda/camunda-modeler#3622