Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(condition): correctly apply allOf condition #135

Closed
wants to merge 3 commits into from
Closed

fix(condition): correctly apply allOf condition #135

wants to merge 3 commits into from

Conversation

marstamm
Copy link
Member

@marstamm marstamm commented Feb 9, 2024 •
edited
Loading

closes #133

@marstamm marstamm self-assigned this Feb 9, 2024
This was referenced Feb 9, 2024
Closed
Closed
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 9, 2024
@marstamm
Copy link
Member Author

marstamm commented Feb 9, 2024

I just found out that all choices with conditions always fail as well. I added testcases to the branch.

We should revert this Feature until we are sure it works as intended.

@marstamm marstamm closed this Feb 9, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 9, 2024
@barmac barmac mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme Awaiting requested review from philippfromme

@barmac barmac Awaiting requested review from barmac

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid "allOf" condition marked as invalid
1 participant
@marstamm