feat: support placeholder property
#144
Conversation
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
| placeholder: 'This field has a placeholder' | ||
| }, | ||
| { | ||
| label: 'Input with placeholder', |
There was a problem hiding this comment.
Do I remember correctly that we assume a string/text type in these cases?
There was a problem hiding this comment.
Yes, you do. This is why placeholder should be supported in such properties.
| @@ -0,0 +1,72 @@ | |||
| export const template = { | |||
There was a problem hiding this comment.
Question: We decided to only support it for C8?
There was a problem hiding this comment.
We could implement it for both platforms, but that means greater effort in bpmn-js-element-templates project.
There was a problem hiding this comment.
Though it really feels like a core element template issue thing that should not depend on a specific platform.
There was a problem hiding this comment.
We'll be able to port it over, one day.
There was a problem hiding this comment.
Let's have it in the core then.
There was a problem hiding this comment.
Looks good to me. Just #144 (comment) to consider (parity between C7 and C8).
This PR add support for
placeholderproperty onStringandTextfields.Related to bpmn-io/bpmn-js-element-templates#92