feat: support engines property #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Since we agreed not to have any additional validation for semver here, it's ready for review. Question: Do we agree on It should be |
bpmn-io-tasks
bot
added
needs review
nikku
reviewed
Dec 6, 2024
packages/zeebe-element-templates-json-schema/src/defs/engines.json
Outdated
Show resolved
Hide resolved
nikku
reviewed
Dec 6, 2024
nikku
reviewed
Dec 6, 2024
packages/zeebe-element-templates-json-schema/src/defs/engines.json
Outdated
Show resolved
Hide resolved
nikku
reviewed
Dec 6, 2024
packages/zeebe-element-templates-json-schema/src/defs/engines.json
Outdated
Show resolved
Hide resolved
nikku
reviewed
Dec 6, 2024
packages/zeebe-element-templates-json-schema/test/spec/validationSpec.js
Outdated
Show resolved
Hide resolved
`engines` is a new property that allows templates to declare compatibility with other run-time provided engines. Closes #146
nikku
approved these changes
Dec 6, 2024
nikku
added a commit
to bpmn-io/bpmn-js-element-templates
that referenced
this pull request
Dec 11, 2024
feat: support <engines> field in schema validation See https://github.com/camunda/element-templates-json-schema/blob/main/packages/zeebe-element-templates-json-schema/CHANGELOG.md#0210 Related to camunda/element-templates-json-schema#152
jarekdanielak
pushed a commit
to bpmn-io/bpmn-js-element-templates
that referenced
this pull request
Dec 11, 2024
feat: support <engines> field in schema validation See https://github.com/camunda/element-templates-json-schema/blob/main/packages/zeebe-element-templates-json-schema/CHANGELOG.md#0210 Related to camunda/element-templates-json-schema#152
nikku
added a commit
to bpmn-io/bpmn-js-element-templates
that referenced
this pull request
Dec 12, 2024
feat: support <engines> field in schema validation See https://github.com/camunda/element-templates-json-schema/blob/main/packages/zeebe-element-templates-json-schema/CHANGELOG.md#0210 Related to camunda/element-templates-json-schema#152
jarekdanielak
pushed a commit
to bpmn-io/bpmn-js-element-templates
that referenced
this pull request
Dec 12, 2024
feat: support <engines> field in schema validation See https://github.com/camunda/element-templates-json-schema/blob/main/packages/zeebe-element-templates-json-schema/CHANGELOG.md#0210 Related to camunda/element-templates-json-schema#152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
Add
enginesproperty to include a list of platforms and their versions compatible with element template.