Camunda 24303 fix action path #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmur2
reviewed
Dec 19, 2024
Comment on lines
+41
to
+45
| - name: Symlink current action repo | ||
| env: | ||
| action_path: ${{ github.action_path }} | ||
| run: ln -fs ${{ env.action_path }}/.. .github/.linked-infra-global-github-actions | ||
| shell: bash |
There was a problem hiding this comment.
This workaround is necessary as per https://github.com/orgs/community/discussions/41927
cmur2
requested changes
Dec 19, 2024
| run: | | ||
| IS_PR_EVENT=${{ github.event_name == 'pull_request' }} | ||
| HAS_NO_CACHE_LABEL=${{ contains(github.event.pull_request.labels.*.name, 'ci:no-cache') }} | ||
| IS_FEATURE_BRANCH=${{ !(startsWith(github.ref_name, 'stable/') || github.ref_name == 'main') }} |
There was a problem hiding this comment.
Introduce and respect the cache_create_branch_regex input that setup-yarn-cache action has - to allow universal use also outside of camunda/camunda repo.
Kerruba
added a commit
that referenced
this pull request
Dec 20, 2024
I've moved the setup-yarn-cache code (and its dependency on is-cache-enabled) to a dedicated PR. This commit has been used also for testing on the monorepo - camunda/camunda#26294 This will replace: - #318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for implementing the cache disable mechanism but in a way that actually works when referencing the
is-cache-enabledcomposite action