Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kelkawi-a committed Jul 11, 2024
1 parent a921462 commit 77b216e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
4 changes: 0 additions & 4 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ links:
source: https://github.com/canonical/airbyte-k8s-operator
issues: https://github.com/canonical/airbyte-k8s-operator/issues

assumes:
- k8s-api
- juju >= 3.1

# (Required for 'charm' type)
bases:
- build-on:
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/test_structured_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def test_config_parsing_parameters_integer_values(_harness) -> None:
check_valid_values(_harness, field, valid_values)


def test_product_related_values(_harness) -> None:
"""Test specific parameters for each field."""
def test_application_related_values(_harness) -> None:
"""Test specific parameters for application-related fields."""
erroneus_values = ["test-value", "foo", "bar"]

# storage-type
Expand All @@ -48,15 +48,15 @@ def test_product_related_values(_harness) -> None:


def test_cpu_related_values(_harness) -> None:
"""Test specific parameters for each field."""
"""Test specific parameters for cpu-related fields."""
erroneus_values = ["-123", "0", "100f"]
check_invalid_values(_harness, "job-main-container-cpu-limit", erroneus_values)
accepted_values = ["200m", "4"]
check_valid_values(_harness, "job-main-container-cpu-limit", accepted_values)


def test_memory_related_values(_harness) -> None:
"""Test specific parameters for each field."""
"""Test specific parameters for memory-related fields."""
erroneus_values = ["-123", "0", "100f"]
check_invalid_values(_harness, "job-main-container-memory-limit", erroneus_values)
accepted_values = ["4Gi", "256Mi"]
Expand Down
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ max-line-length=120
[vars]
src_path = {tox_root}/src
tests_path = {tox_root}/tests
;lib_path = {tox_root}/lib/charms/operator_name_with_underscores
all_path = {[vars]src_path} {[vars]tests_path}

[testenv]
Expand Down

0 comments on commit 77b216e

Please sign in to comment.