Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document how to find mysql backup file and print path in output #589

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Oct 18, 2024

  • Print backup file path on output
  • Refactor how-to backup document, add information where to find the file.

gabrielcocenza
gabrielcocenza previously approved these changes Oct 18, 2024
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jneo8 is this addressing #492 ?

docs/how-to/find-mysql-backup-file.rst Outdated Show resolved Hide resolved
cou/steps/backup.py Outdated Show resolved Hide resolved
cou/steps/backup.py Outdated Show resolved Hide resolved
chanchiwai-ray
chanchiwai-ray previously approved these changes Oct 21, 2024
docs/how-to/find-mysql-backup-file.rst Outdated Show resolved Hide resolved
docs/how-to/find-mysql-backup-file.rst Outdated Show resolved Hide resolved
samuelallan72
samuelallan72 previously approved these changes Oct 21, 2024
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/how-to/backup.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title of this is "docs: Add document how to find mysql backup file" and you are changing also the code. Can you align it and provide output example? Thanks

cou/steps/backup.py Outdated Show resolved Hide resolved
@jneo8 jneo8 changed the title docs: Add document how to find mysql backup file Add document how to find mysql backup file and print path in output Oct 22, 2024
@jneo8
Copy link
Contributor Author

jneo8 commented Oct 22, 2024

Title of this is "docs: Add document how to find mysql backup file" and you are changing also the code. Can you align it and provide output example? Thanks

Updated

chanchiwai-ray
chanchiwai-ray previously approved these changes Oct 22, 2024
cou/steps/backup.py Outdated Show resolved Hide resolved
cou/steps/backup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for making the changes, I think that makes it clearer for future readers. :)

@samuelallan72 samuelallan72 merged commit cdd59a8 into main Oct 23, 2024
8 checks passed
@samuelallan72 samuelallan72 deleted the doc/how-to-find-mysql-backup branch October 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants