Skip to content

Commit

Permalink
Add internal microphone manifest and update some audio jobs requireme…
Browse files Browse the repository at this point in the history
…nts (bugfix) (#1594)

Add "internal microphone" manifest entry

Devices without an internal microphone should not run the
`audio/alsa_record_playback_internal` job, as it requires one.

This issue was detected when reviewing test results to issue a
certificate for a desktop PC. The `audio/alsa_record_playback_internal`
job was marked as skipped, but it is a certification-blocker, so it
triggered some alerts.
  • Loading branch information
pieqq authored Nov 12, 2024
1 parent b2822b6 commit 07fe80a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion providers/base/units/audio/jobs.pxu
Original file line number Diff line number Diff line change
Expand Up @@ -337,9 +337,9 @@ estimated_duration: 20.0
depends: audio/playback_auto
imports: from com.canonical.plainbox import manifest
requires:
(manifest.has_line_in == 'True' or manifest.has_headset == 'True')
manifest.has_audio_playback == 'True'
manifest.has_audio_capture == 'True'
manifest.has_internal_microphone == 'True'
package.name == 'alsa-base'
package.name == 'gstreamer1.0-plugins-good' or package.name == 'gstreamer0.10-plugins-good'
package.name in ['pulseaudio-utils', 'pipewire']
Expand Down
11 changes: 9 additions & 2 deletions providers/base/units/audio/manifest.pxu
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Copyright 2017 Canonical Ltd.
# Copyright 2017-2024 Canonical Ltd.
# All rights reserved.
#
# Written by:
# Sylvain Pineau <[email protected]>
# Sylvain Pineau <[email protected]>
# Pierre Equoy <[email protected]>

unit: manifest entry
id: has_audio_playback
Expand Down Expand Up @@ -45,3 +46,9 @@ id: has_internal_speakers
_name: Internal speakers
_prompt: Does this machine have the following audio features?
value-type: bool

unit: manifest entry
id: has_internal_microphone
_name: Internal microphone
_prompt: Does this machine have the following audio features?
value-type: bool

0 comments on commit 07fe80a

Please sign in to comment.