Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkbox-ce-oem] add iio sensors test (New) #1036

Merged
merged 13 commits into from
Mar 19, 2024
Merged

[checkbox-ce-oem] add iio sensors test (New) #1036

merged 13 commits into from
Mar 19, 2024

Conversation

stanley31huang
Copy link
Collaborator

@stanley31huang stanley31huang commented Mar 5, 2024 •
edited
Loading

Description

Implement new test cases for industrial I/O sensor

Resolved issues

N/A

Documentation

Refer to the kernel document about the Industrial I/O sensor
https://www.kernel.org/doc/html/v5.4/driver-api/iio/core.html#industrial-i-o-devices

Tests

Tested on Murcia project, please refer the test results from C3 website.
https://certification.canonical.com/hardware/202312-33237/submission/359230/

List-bootstrapped logs

stanley@stanley-ThinkPad-T490:~$ checkbox-cli list-bootstrapped com.canonical.contrib::ce-oem-iio-sensors-full
Using sideloaded provider: checkbox-provider-ce-oem, version 0.1 from /var/tmp/checkbox-providers/checkbox-provider-ce-oem
Skipped file: /usr/share/checkbox-provider-base/units/camera/README.rst
Skipped file: /usr/share/checkbox-provider-base/units/snapd/README.md
Skipped file: /usr/share/checkbox-provider-base/units/stress/suspend_cycles_reboot.md
Using sideloaded provider: checkbox-provider-ce-oem, version 0.1 from /var/tmp/checkbox-providers/checkbox-provider-ce-oem
com.canonical.plainbox::manifest
com.canonical.contrib::ce-oem-iio-sensors/check-pressure-0
com.canonical.certification::rtc
com.canonical.certification::sleep
com.canonical.certification::suspend/suspend_advanced_auto
com.canonical.contrib::after-suspend-ce-oem-iio-sensors/check-pressure-0
com.canonical.contrib::ce-oem-iio-sensors/check-accelerometer-1
com.canonical.contrib::after-suspend-ce-oem-iio-sensors/check-accelerometer-1
com.canonical.contrib::ce-oem-iio-sensors/check-humidityrelative-2
com.canonical.contrib::after-suspend-ce-oem-iio-sensors/check-humidityrelative-2

@stanley31huang
Add: implement iio sensors test
02bedc6 
implement iio sensor tests
@stanley31huang
add dump resource function
4e08c38 
add sub parser to support dump iio sensor resource
@stanley31huang
add unittest and refactor iio sensor test
512875c 
add unittest and refactor iio sensor test
@stanley31huang stanley31huang requested a review from a team as a code owner March 5, 2024 07:08
@stanley31huang
Fix: fixed template job issue
3321b1e 
fixed template job issue
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.65%. Comparing base (7dd40a1) to head (cfe645a).
Report is 31 commits behind head on main.

❗ Current head cfe645a differs from pull request most recent head f21568f. Consider uploading reports for the commit f21568f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
+ Coverage   40.52%   40.65%   +0.12%     
==========================================
  Files         335      336       +1     
  Lines       37365    37445      +80     
  Branches     6348     6358      +10     
==========================================
+ Hits        15143    15223      +80     
  Misses      21585    21585              
  Partials      637      637
Flag Coverage Δ
contrib-provider-ce-oem 32.35% <100.00%> (+2.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stanley31huang
Fix: PEP8 issue
d888e87 
fixed PEP8 issue
@stanley31huang
improve unittest coverage
94c98d1 
improve unittest coverage
@stanley31huang
add iio sensors test plan as nested part of ce-oem
0b5016d 
add iio sensors test plan as part of nested test plan of ce-oem plans
baconYao
baconYao previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley31huang
Add author information into python scripts
cfe645a 
add author information into python scripts
rickwu666666
rickwu666666 reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor question. Please see my in-line comment.
Otherwise LGTM

contrib/checkbox-provider-ce-oem/units/iio-sensors/test-plan.pxu Outdated Show resolved Hide resolved
@stanley31huang
Fix: applied template id for iio sensor tests
adbde40 
applied templdate id for iio sensor tests
rickwu666666
rickwu666666 previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley31huang
Add new iio-sensors test plans
19c0b87 
add new iio-sensors test plans
baconYao
baconYao previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LiaoU3
LiaoU3 requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment.

contrib/checkbox-provider-ce-oem/bin/iio_sensor_test.py Outdated Show resolved Hide resolved
contrib/checkbox-provider-ce-oem/units/test-plan-ce-oem.pxu Outdated Show resolved Hide resolved
@stanley31huang
Fixed: fixed bugs
4add0b0 
fixed bugs
LiaoU3
LiaoU3 requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

contrib/checkbox-provider-ce-oem/units/test-plan-ce-oem.pxu Outdated Show resolved Hide resolved
contrib/checkbox-provider-ce-oem/bin/iio_sensor_test.py Outdated Show resolved Hide resolved
LiaoU3
LiaoU3 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rickwu666666
rickwu666666 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley31huang stanley31huang merged commit c4659a7 into canonical:main Mar 19, 2024
6 checks passed
@stanley31huang stanley31huang deleted the 240226_iio-sensors branch March 19, 2024 13:47
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
@stanley31huang @binli
[checkbox-ce-oem] add iio sensors test (New) (canonical#1036)
5f30613 
* Add: implement iio sensors test

implement iio sensor tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickwu666666 rickwu666666 rickwu666666 approved these changes

@LiaoU3 LiaoU3 LiaoU3 approved these changes

@baconYao baconYao baconYao left review comments

@zongminl zongminl Awaiting requested review from zongminl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stanley31huang @baconYao @LiaoU3 @rickwu666666