Cover smaller genio tests (New) #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved check_env_variables to function so the module can be imported without requiring them - Added choices for devices considered in the test - Test failing with wrong verify output
|
I tried to modify the code as little as possible. There were some mistakes that I had to fix to be able to run the unit-tests, but there are still many small things on the test that could be simplified, made more clear, and more general. |
|
Here you can have the coverage in html: |
kissiel
previously approved these changes
Mar 13, 2024
Co-authored-by: kissiel <[email protected]>
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Formatted dvfs test and removed typos * Added test for dvfs_gpu_check_governors * Raise SystemExit only on fail * Added serialcheck tests * Fixed Error raise when stdout is empty * Added spidev test * Added pmic regulator tests * Fixed errors in linux_ccf - Moved check_env_variables to function so the module can be imported without requiring them - Added choices for devices considered in the test - Test failing with wrong verify output * Added linux ccf tests * Update contrib/genio/bin/spidev_test.py Co-authored-by: kissiel <[email protected]> --------- Co-authored-by: kissiel <[email protected]>
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Formatted dvfs test and removed typos * Added test for dvfs_gpu_check_governors * Raise SystemExit only on fail * Added serialcheck tests * Fixed Error raise when stdout is empty * Added spidev test * Added pmic regulator tests * Fixed errors in linux_ccf - Moved check_env_variables to function so the module can be imported without requiring them - Added choices for devices considered in the test - Test failing with wrong verify output * Added linux ccf tests * Update contrib/genio/bin/spidev_test.py Co-authored-by: kissiel <[email protected]> --------- Co-authored-by: kissiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the inclusion of genio tests on the contrib area of checkbox, we have to add unit-tests to ensure the coverage requirements are satisfied. We have included unit-tests for the scripts with less than 100 LOC
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-996
Documentation
There are no changes to the documentation
Tests
To run the unittests:
Coverage Report