Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feild name for scaling_test and maxfreq_test log attach from after to depeneds (Bugfix) #1069

Merged

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Mar 15, 2024

Description

This is a simple PR to fix the mistakes from previous commit.
Fix field from after to depends.

Resolved issues

#996

Documentation

N/A

Tests

N/A

@LiaoU3 LiaoU3 requested a review from weizhenwu March 15, 2024 09:43
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.92%. Comparing base (539ec18) to head (c892927).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   40.92%   40.92%           
=======================================
  Files         337      337           
  Lines       37547    37547           
  Branches     6383     6383           
=======================================
  Hits        15365    15365           
  Misses      21543    21543           
  Partials      639      639           
Flag Coverage Δ
provider-base 13.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hook25 Hook25 merged commit 9ca358b into canonical:main Mar 15, 2024
12 checks passed
fernando79513 pushed a commit that referenced this pull request Mar 18, 2024
…r to depeneds (Bugfix) (#1069)

Fix flags for scaling_test and maxfreq_test log attach
LiaoU3 added a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
…r to depeneds (Bugfix) (canonical#1069)

Fix flags for scaling_test and maxfreq_test log attach
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
…r to depeneds (Bugfix) (canonical#1069)

Fix flags for scaling_test and maxfreq_test log attach
@LiaoU3 LiaoU3 deleted the fix_flags_for_maxfreq_test_scaling_test branch April 2, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants