Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the suspend/resume threshold variable (Bugfix) #1078

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

seankingyang
Copy link
Contributor

@seankingyang seankingyang commented Mar 18, 2024

Description

Correct the suspend/resume threshold variable mapping.
From

echo "resume_threshold: ${STRESS_SUSPEND_SLEEP_THRESHOLD:-10}"
echo "sleep_threshold: ${STRESS_SUSPEND_RESUME_THRESHOLD:-5}"

To

echo "resume_threshold: ${STRESS_SUSPEND_RESUME_THRESHOLD:-5}"
echo "sleep_threshold: ${STRESS_SUSPEND_SLEEP_THRESHOLD:-10}"

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.92%. Comparing base (44498aa) to head (320e3b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   40.92%   40.92%           
=======================================
  Files         337      337           
  Lines       37548    37548           
  Branches     6384     6384           
=======================================
  Hits        15366    15366           
  Misses      21543    21543           
  Partials      639      639           
Flag Coverage Δ
provider-base 13.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seankingyang seankingyang changed the title Correct the suspend/resume variable mapping in suspend cycles(Bugfix) Correct the suspend/resume variable (Bugfix) Mar 18, 2024
@seankingyang seankingyang changed the title Correct the suspend/resume variable (Bugfix) Correct the suspend/resume threshold variable (Bugfix) Mar 18, 2024
Copy link
Contributor

@diohe0311 diohe0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@Hook25 Hook25 merged commit 9ec0b3c into canonical:main Mar 18, 2024
17 checks passed
fernando79513 pushed a commit that referenced this pull request Mar 18, 2024
Correct the suspend/resume variable mapping in suspend cycles with reboot
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
Correct the suspend/resume variable mapping in suspend cycles with reboot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants