Take inline overrides into account in mandatory_include and bootstrap_include sections of a test plan (BugFix) #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test plan
Although inline overrides were taking into account in the `include`
section of a test plan, it was not the case for the `mandatory_include`
section.
So a test plan like this:
unit: test plan
id: test-plan
name: My test plan
mandatory_include:
mandatory-cert-blocker-job certification_status=blocker
include:
regular-cert-blocker-job certification_status=blocker
would only make "regular-cert-blocker-job" a cert-blocker, not
"mandatory-cert-blocker-job".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 40.92% 40.99% +0.07%
==========================================
Files 337 337
Lines 37548 37552 +4
Branches 6384 6385 +1
==========================================
+ Hits 15366 15396 +30
+ Misses 21543 21517 -26
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Move the V class one level above, so it can be used for the different include sections of the test plan. - Fix issue found by Max (`mandatory_include` was parsed only if there was an `include` section) - Add support for `bootstrap_include` for good measure
pieqq
changed the title
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…_include sections of a test plan (BugFix) (canonical#1079) * Take inline overrides into account in mandatory_include section of a test plan Although inline overrides were taking into account in the `include` section of a test plan, it was not the case for the `mandatory_include` section. So a test plan like this: unit: test plan id: test-plan name: My test plan mandatory_include: mandatory-cert-blocker-job certification_status=blocker include: regular-cert-blocker-job certification_status=blocker would only make "regular-cert-blocker-job" a cert-blocker, not "mandatory-cert-blocker-job". * Add support for bootstrap_include section - Move the V class one level above, so it can be used for the different include sections of the test plan. - Fix issue found by Max (`mandatory_include` was parsed only if there was an `include` section) - Add support for `bootstrap_include` for good measure * Add unit test to check bootstrap_include inline overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although inline overrides were taking into account in the
includesection of a test plan, it was not the case for themandatory_includeandbootstrap_includesections.So a test plan like this:
would only make "regular-cert-blocker-job" a cert-blocker, not "mandatory-cert-blocker-job".
Resolved issues
Tests
Tested by running a test plan similar as the one described above and making sure the HTML report includes the job in
mandatory_includeandbootstrap_includesections as a cert-blocker.