Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template-id fields to template units (infra) #1137

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

tang-mm
Copy link
Collaborator

@tang-mm tang-mm commented Apr 2, 2024

Description

The checkbox-cli list template command will return a template-id value derived from its id field, which is not present in the pxu file. Adding the values are fixed fields so that potential changes in the template id will not affect the test plans that reference them.

Values are referenced by #1127

Resolved issues

Part of CHECKBOX-1295

Documentation

N/A

Tests

N/A

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.92%. Comparing base (1c6026d) to head (4ec056c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   42.92%   42.92%           
=======================================
  Files         352      352           
  Lines       38493    38493           
  Branches     6540     6540           
=======================================
  Hits        16525    16525           
  Misses      21302    21302           
  Partials      666      666           
Flag Coverage Δ
provider-base 15.54% <ø> (ø)
provider-resource 27.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, ty for going through all of them

@Hook25 Hook25 merged commit b8befd8 into main Apr 3, 2024
22 checks passed
@Hook25 Hook25 deleted the add-template-id branch April 3, 2024 15:04
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants