-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check power mode before and after suspend (New) #1145
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
- Coverage 44.10% 43.04% -1.06%
==========================================
Files 358 355 -3
Lines 38765 38572 -193
Branches 6571 6549 -22
==========================================
- Hits 17096 16604 -492
- Misses 21006 21302 +296
- Partials 663 666 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suspend story is sadly still to be defined, so this doesn't do what you think it will do. Please consider using one job that has an also-after-suspend flag and:
- if the power mode file doesn't exist, it creates it
- if the power mode file exists, it diffs it
This doesn't 100% work (as re-runs are a thing), but is more correct than what this PR would yield
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but it doesn't do what you think it will. The issue here is that while the after_suspend job runs after suspend (due to the dependency), the before suspend may itself run after suspend, making the job pointless. Recently we have made this change #1037, so you can use the also-after-suspend
flag to get the result you want (I see that this is a specific suspend job, so idk if it is the same for you as the normal suspend job).
2cb1442
to
ebf8361
Compare
Description
With Platform Profile (low-power, balanced, performance) support being added to the kernel and GNOME we'd like this to be tested to confirm it is working during HW enablement/certification.
It is expected functionality on these platforms and we need to highlight any issues with it not working to the FW team so it can be fixed before preload signoff.
Resolved issues
Original bug: https://bugs.launchpad.net/sutton/+bug/2036435
Documentation
This testcase could help verify power mode can stay in the chosen setting after suspend.
Tests