Bring back kernel/snapd/gadget snaps revert/refresh jobs to the SRU test plan (BugFix) #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est plan The snap-refresh-revert nested part had been removed from the SRU test plan in cd17d9a following some discoveries that, when executed, the jobs executed would change the system state in the wrong order (e.g. updating the kernel snap without reverting it while running other jobs afterwards). The jobs were modified to prevent this kind of scenario[1], and the use of manifest entries[2] prevents the jobs from being run on all the devices yet (currently, the only project that enables them is the Xinyi project). Fix LM-1522 [1] #1124 [2] https://github.com/canonical/checkbox/tree/main/providers/base/units/snapd#manifest-entries
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 43.15% 43.15%
=======================================
Files 355 355
Lines 38627 38627
Branches 6556 6556
=======================================
Hits 16668 16668
Misses 21294 21294
Partials 665 665
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Apr 17, 2024
…est plan (BugFix) (canonical#1176) Bring back kernel/snapd/gadget snaps revert/refresh jobs to the SRU test plan The snap-refresh-revert nested part had been removed from the SRU test plan in cd17d9a following some discoveries that, when executed, the jobs executed would change the system state in the wrong order (e.g. updating the kernel snap without reverting it while running other jobs afterwards). The jobs were modified to prevent this kind of scenario[1], and the use of manifest entries[2] prevents the jobs from being run on all the devices yet (currently, the only project that enables them is the Xinyi project). Fix LM-1522 [1] canonical#1124 [2] https://github.com/canonical/checkbox/tree/main/providers/base/units/snapd#manifest-entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The snap-refresh-revert nested part had been removed from the SRU test plan in cd17d9a following some discoveries that, when executed, the jobs executed would change the system state in the wrong order (e.g. updating the kernel snap without reverting it while running other jobs afterwards).
The jobs were modified to prevent this kind of scenario, and the use of manifest entries prevents the jobs from being run on all the devices yet (currently, the only project that enables them is the Xinyi project).
Resolved issues
Fix LM-1522
Documentation
Tests
Tested on Xinyi with a local build of Checkbox.