Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] checkbox-ce-oem change to daily build (Infra) #1182

Closed
wants to merge 4 commits into from

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Apr 15, 2024

Description

Make checkbox-ce-oem from building when commit to building daily.

Resolved issues

N/A

Documentation

N/A

Tests

https://github.com/canonical/checkbox/actions/runs/8682803386

@LiaoU3 LiaoU3 marked this pull request as ready for review April 15, 2024 03:42
@LiaoU3 LiaoU3 requested a review from Hook25 April 15, 2024 03:43
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to adding this to daily build but we use the status of daily build also to decide if we can promote a beta version of checkbox so I have to know. How reliable is that snap build? Does it build all the times or does it seldomly fail?

Also, small tweek below, needed to actually trigger if there are new commits to contrib.

.github/workflows/daily-builds.yml Show resolved Hide resolved
@Hook25
Copy link
Collaborator

Hook25 commented Apr 15, 2024

The black formatting ierror should be now fixed in main, rebase the PR, it should be ok

@LiaoU3 LiaoU3 force-pushed the checkbox-ce-oem_daily_build branch from dc654b8 to 15febb4 Compare April 15, 2024 07:28
@LiaoU3 LiaoU3 closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants