-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modprobe_attachment and sysctl_attachment failed in remote mode (BugFix) #1214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 43.32% 43.32%
=======================================
Files 356 356
Lines 38658 38658
Branches 6559 6559
=======================================
Hits 16750 16750
Misses 21245 21245
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, before merging this can you copy-paste here the error message so that we can see that this is a permission error? (the link in your report is broken for some reason)
the error info before the fix:Outcome: job passed
|
We are having some problems with the uploads today, here are the outputs, the fix works: (these are submissions.html -> pdf because GH doesn't like html files) |
@Hook25 thank you for your quick merge! |
Uploading test-result.zip…
When run the information attachment job in remote mode, the sysctl_attachment and modprobe_attachment always failed. If I run it with the root user, the job will be passed without problem.
Description
The sysctl_attachment and modprobe_attachment job will failed in remote mode.
Resolved issues
The sysctl_attachment and modprobe_attachment job will failed in remote mode.
Documentation
Tests
Attached the test report for which run the test before the fix in local/remote mode, after the fix in local/remote mode.