Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core24 builds action (infra) #1215

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Core24 builds action (infra) #1215

merged 3 commits into from
Apr 29, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Apr 29, 2024

Description

This updates the core24 build action so that it works, fixing several problems:

  • artifact upload v3 is deprecated -> moved to v4 (renamed the artifact as the new v4 action doesn't allow to have multiple uploads with the same name)
  • sloppy copy paste in matrix strategy, runtime has no classic/uc devide
  • Use group to avoid building on testflinger runners (several reasons, firewall issues and overall not their purpose)
  • Fix the libamdhip64 workaroud by installing execstack in build-packages instead of stage-packages
  • Error checking on the execstack bitsetting (nice to have)
  • Fix the workaroud by running the prime part AFTER setting the bit instead of before

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1420

Documentation

N/A

Tests

Checkbox24 currently in the store was built from this branch

Use artifact name that is unique per matrix
Use v4 instead of v3 upload action
Set group and label to avoid TF runners as well
Select also tag to not use TF runners
Wrong copy pasted matrix variable
Remove alegedly outdated workaroud
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, +1

@kissiel kissiel merged commit 6adf790 into main Apr 29, 2024
5 checks passed
@kissiel kissiel deleted the core24_builds_experiment branch April 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants