Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iot-cert-image-automated from ODM Server Test Plan (BugFix) #1218

Conversation

baconYao
Copy link
Contributor

@baconYao baconYao commented Apr 30, 2024

Description

Since the jobs included in iot-cert-image-automated test plan is suitable for Ubuntu Core image only, therefore, remove it from client-cert-odm-server-22-04.pxu and client-cert-odm-server-24-04.pxu plans.

Resolved issues

This is the submission tested on G1200 Server Image

Since there's no Gadget Kernel snaps in Server image, hence, all the jobs are failed except image/model-grade is skip.

Documentation

N/A

Tests

1. Since the jobs included in iot-cert-image-automated test plan is
   suitable for Ubuntu Core image only, therefore, remove it from
client-cert-odm-server-22-04.pxu and client-cert-odm-server-24-04.pxu
plans.

2. Enhance the jobs by adding requires to focus on Ubuntu Core image
   onlt.
@baconYao baconYao requested review from pieqq and kissiel April 30, 2024 01:51
@baconYao baconYao changed the title Remove iot-cert-image-automated from ODM Server Test Plan Remove iot-cert-image-automated from ODM Server Test Plan (New) Apr 30, 2024
@baconYao baconYao changed the title Remove iot-cert-image-automated from ODM Server Test Plan (New) Remove iot-cert-image-automated from ODM Server Test Plan (BugFix) Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.36%. Comparing base (070d2fc) to head (84cd4a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   43.36%   43.36%           
=======================================
  Files         357      357           
  Lines       38684    38684           
  Branches     6560     6560           
=======================================
  Hits        16776    16776           
  Misses      21245    21245           
  Partials      663      663           
Flag Coverage Δ
provider-certification-client 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you

@baconYao
Copy link
Contributor Author

baconYao commented May 3, 2024

Hi @pieqq, @kissiel, could you help review this? Thanks

@zongminl zongminl merged commit e29ba21 into main May 3, 2024
14 checks passed
@zongminl zongminl deleted the remove_iot-cert-image-automated_test_plan_from_odm_server_test_plan branch May 3, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants