Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pm-graph from SRU test plans (bugfix) #1244

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

jocave
Copy link
Collaborator

@jocave jocave commented May 10, 2024

Removes pm-graph tests from SRU server plan from where it is inherited by the plan used for desktop machines.

Description

pm-graph has been described as "designed with single user mode not graphics multi-user mode" and it is found to often block test session completion which slows ability to approve kernels.

If this is needed for any specific benchmarking reasons it needs to be made more reliable on all machines that run the test plan and potential run separately from SRU

Also note that this does not remove pm-graph from the Certification test plans.

Resolved issues

Documentation

Tests

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is a discussion that has been brewing also with SW enablement team. Thanks!

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.38%. Comparing base (ec16636) to head (8550286).
Report is 116 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1244   +/-   ##
=======================================
  Coverage   43.38%   43.38%           
=======================================
  Files         357      357           
  Lines       38686    38686           
  Branches     6561     6561           
=======================================
  Hits        16784    16784           
  Misses      21238    21238           
  Partials      664      664           
Flag Coverage Δ
provider-sru 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hook25 Hook25 changed the title Remove pm-graph from SRU test plans Remove pm-graph from SRU test plans (bugfix) May 23, 2024
@Hook25 Hook25 merged commit 4020cd1 into main May 23, 2024
8 checks passed
@Hook25 Hook25 deleted the sru-remove-pm-graph branch May 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants