Added SSL check to checkbox support (BugFix) #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 43.37% 43.51% +0.13%
==========================================
Files 357 357
Lines 38693 38706 +13
Branches 6561 6564 +3
==========================================
+ Hits 16784 16841 +57
+ Misses 21245 21200 -45
- Partials 664 665 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fernando79513
force-pushed
the
fix-python35-pip-certificate-issue
branch
3 times, most recently
from
f87e00e
to
1fe2703
Compare
fernando79513
force-pushed
the
fix-python35-pip-certificate-issue
branch
from
1fe2703
to
1b01e6e
Compare
fernando79513
force-pushed
the
fix-python35-pip-certificate-issue
branch
from
c79a131
to
e015993
Compare
Hook25
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.5 setup was failing because of a
CERTIFICATE_VERIFY_FAILEDerror. To fix this, we have set up manuallyPIP_TRUSTED_HOST, checking first that we can "curl" the hosts, since they will fail in case of expired/invalid/self-signed certificateResolved issues
Documentation
N/A
Tests
The pipelines have been run with this changes and are all passing