Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the desktop recommand from sru and sru-server (bugfix) #1378

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jul 30, 2024

Description

As per this meeting minute we have to remove this test from SRU as it is used in enablement but not in sru

Resolved issues

Fixes: CER-2694

Documentation

N/A

Tests

Test is no longer in sru or sru-destktop:

# on main
$ checkbox-cli expand com.canonical.certification::sru-server | grep ubuntu-desktop | wc -l
2
$ checkbox-cli expand com.canonical.certification::sru | grep ubuntu-desktop | wc -l
2
# this branch 
$ checkbox-cli expand com.canonical.certification::sru-server | grep ubuntu-desktop | wc -l
0
$ checkbox-cli expand com.canonical.certification::sru | grep ubuntu-desktop | wc -l
0

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.12%. Comparing base (9639ba7) to head (e89ba50).
Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files         366      366           
  Lines       39058    39058           
  Branches     6607     6607           
=======================================
  Hits        17626    17626           
  Misses      20758    20758           
  Partials      674      674           
Flag Coverage Δ
provider-sru 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jocave jocave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you

@jocave jocave merged commit c09a4ce into main Jul 30, 2024
39 checks passed
@jocave jocave deleted the drop_ubu_desktop branch July 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants