Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle warnings in dkms status (BugFix) #1415

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Handle warnings in dkms status (BugFix) #1415

merged 2 commits into from
Aug 15, 2024

Conversation

jocave
Copy link
Collaborator

@jocave jocave commented Aug 12, 2024

Description

In some SRU runs with encountered dkms status output which included a warning. The dkms source seems to imply this is could be of interest to a user but not an error so therefore handling it in the test without a failures

Resolved issues

Documentation

Tests

Extra unit test added and tested on machine dell-latitude7640-c31002

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.19%. Comparing base (dfae162) to head (cc2faea).
Report is 122 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   45.18%   45.19%           
=======================================
  Files         366      366           
  Lines       39107    39113    +6     
  Branches     6612     6613    +1     
=======================================
+ Hits        17670    17676    +6     
  Misses      20764    20764           
  Partials      673      673           
Flag Coverage Δ
provider-sru 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hook25
Hook25 previously approved these changes Aug 12, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider printing or dumping to stderr that rest if you want

providers/sru/bin/dkms_build_validation.py Show resolved Hide resolved
@Hook25 Hook25 merged commit 21817f1 into main Aug 15, 2024
43 checks passed
@Hook25 Hook25 deleted the dkms-with-warning branch August 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants