Fix snap refresh verification job dependency (bugfix) #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing changes for the gadget/snapd/kernel snap refresh[1],
one of the job dependencies was not updated properly.
The `snapd/reboot-after-snap-refresh-{type}-{name}-to-stable-rev` job
does not exist anymore, so the
`snapd/snap-verify-after-refresh-{type}-{name}-to-stable-rev` should
depend on the refresh job itself (which was modified in the
aforementioned PR to do the reboot itself)
[1]: #1124
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 47.56% 47.56%
=======================================
Files 369 369
Lines 39596 39596
Branches 6691 6691
=======================================
Hits 18833 18833
Misses 20051 20051
Partials 712 712
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing changes for the gadget/snapd/kernel snap refresh, one of the job dependencies was not updated properly.
The
snapd/reboot-after-snap-refresh-{type}-{name}-to-stable-revjob does not exist anymore, so thesnapd/snap-verify-after-refresh-{type}-{name}-to-stable-revshould depend on the refresh job itself (which was modified in the aforementioned PR to do the reboot itself).Resolved issues
An issue that showed up while testing a customer project:
https://certification.canonical.com/hardware/202302-31257/submission/393904/test-results/?term=cascade-kernel-to-base-rev
See discussion on MM for more information.
Documentation
Tests
Running
checkbox-cli list-bootstrapped com.canonical.certification::snap-refresh-reverton my laptop yield the following results:Before this patch:
After this patch:
(the last 4 jobs are now present that are verifying the snap after an update to stable channel, and then running extra revert and verification steps)